Revert "Added equals macro that handles null value comparison" #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #394
Despite our best efforts to write with good testing coverage, https://github.com/dbt-labs/dbt-core/actions/runs/12472276269/job/34810790864 indicates this logic change continues to break something in dbt-core.
Peter has indicated that there are core tests that they'd like to move to dbt adapters, using which we can adjust & merge this PR. Alternatively, we may use our branch in a local virtual environment and run the dbt-core tests locally. I have raised that we may have done that already (to no avail in catching these tests), so our next steps should be coordinated.
Reverting for the holidays to get us to a green state. This anticipates and guards against any incidents happening overholiday begin blocked by these failing tests.
We can then regroup and plan our next attack.